Refactor Unit Tests for OpenCL Kernels #3601
Open
+2,658
−3,027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeong20
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
dkjung,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
This pull request refactors the unit tests for OpenCL kernels. The changes involve splitting the test files into three categories based on functionality. One for INT4-related tests, another for QK_K (GGML format) tests, and a third for the remaining BLAS tests. Additionally, it consolidates common helper functions used across the test files into separate utility header files. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
force-pushed
the
refactor/opencl
branch
from
182812d to
27fbb41
Compare
songgot
reviewed
Dec 5, 2025
| nntrainer::IniWrapper ini; | ||
| }; | ||
|
|
||
| #define GEN_TEST_INPUT_NHWC(input, eqation_i_j_k_l) \ |
Contributor
There was a problem hiding this comment.
How about keeping the whitespace at the end of each line? And remove file diffs?
Contributor
Author
There was a problem hiding this comment.
I believe the previous version has incorrect formatting, likely due to being formatted with an outdated version.
(The last time this file was edited was a year ago!)
songgot
reviewed
Dec 5, 2025
| // Initialize Activation | ||
| std::vector<float> activation = generate_random_vector<float, false>(M * K); | ||
| float *activations_f32_ptr = (float *)allocateSVM(M * K * sizeof(float)); | ||
| blas_cc->command_queue_inst_.enqueueSVMMap(activations_f32_ptr, |
Contributor
There was a problem hiding this comment.
After use, Right?
blas_cc->command_queue_inst_.enqueueSVMUnmap(activations_f32_ptr, 0, nullptr, nullptr);
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. However, I believe that unmap should be called before kernel execution and should be handled here.
songgot
reviewed
Dec 5, 2025
| // weight 0 (3072 x 3072) | ||
| void *ws0 = allocateSVM(data_size_n0 / scale_group_size); | ||
| void *wq0 = allocateSVM(data_size_n0 / 2); | ||
| blas_cc->command_queue_inst_.enqueueSVMMap(wq0, data_size_n0 / 2, false); |
Contributor
There was a problem hiding this comment.
Isn't 'true' better than 'false'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the unit tests for OpenCL kernels.
The changes involve splitting the test files into three categories based on functionality.
One for INT4-related tests, another for QK_K (GGML format) tests, and a third for the remaining BLAS tests.
Additionally, it consolidates common helper functions used across the test files into separate utility header files.
Self-evaluation: